fix(cli): drop unsupported --no-banner flag for copilotkit v2#1633
Open
and-human wants to merge 1 commit into
Open
fix(cli): drop unsupported --no-banner flag for copilotkit v2#1633and-human wants to merge 1 commit into
and-human wants to merge 1 commit into
Conversation
copilotkit@2.0.0 rewrote its CLI and removed --no-banner. The create-ag-ui-app scaffolder still passes the flag to `npx copilotkit@latest create`, causing "Unknown option '--no-banner'" and aborting project creation whenever a user picks CopilotKit/Next.js. The flag was cosmetic in v1 (banner suppression only) and has no v2 replacement, so removing it is sufficient. The CopilotKit banner now prints during nested creation, which is harmless. Fixes ag-ui-protocol#1627
|
@and-human is attempting to deploy a commit to the CopilotKit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copilotkit@2.0.0(released ~3 days ago) rewrote the CopilotKit CLI and removed the--no-bannerflag.create-ag-ui-appstill passes that flag to the spawnednpx copilotkit@latest create, which now aborts withUnknown option '--no-banner'whenever a user picks CopilotKit/Next.js. This PR drops the unsupported flag from the spawn argv.Reproduction (from #1627)
Fix
const copilotkit = spawn("npx", [ "copilotkit@latest", "create", - "--no-banner", "-n", projectName.name, ...frameworkArgs, ],sdks/typescript/packages/cli/src/index.ts, insidehandleCopilotKitNextJs(). One-line removal.Backward compatibility
The spawn target is hard-coded to
copilotkit@latest, so users always resolve to thelatestdist-tag.latest, what was broken): fixed.--no-bannerwas a cosmetic-q, --no-bannerthat suppressed the banner. Removing the flag means CopilotKit's banner now prints during nested creation — harmless. In practice this path is unreachable since@latestno longer resolves to 1.x.No replacement flag exists in v2 (
copilotkit createv2 only accepts-n -i -f -h).Testing
pnpm --filter create-ag-ui-app build— cleanpnpm --filter create-ag-ui-app typecheck— cleanpnpm --filter create-ag-ui-app test:exports(publint --strict + attw) — clean--mastra, scaffolding completed successfully against currentcopilotkit@latest(projectsmoke-testcreated, noUnknown optionerror).Out of scope (separate follow-up)
Noticed while reading the file: line 113 reads
options.crewiAiFlowswhile line 43 declares the flag ascrewaiFlows(typo:crewivscrewai). CrewAI Flows scaffolding via the framework flag is silently broken — happy to file a follow-up issue/PR after this one merges.Fixes #1627